Fix whitespace not matching in since command.
#778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the since command was failing to replace instances of `n.e.x.t` when more than once space occurred between the `@since` and the placeholder version number, e.g., for docblock alignment purposes.
joemcgill
added
[Type] Bug
felixarntz
approved these changes
Jul 13, 2023
|
@joemcgill Maybe adjust the base branch to |
mukeshpanchal27
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Thanks @joemcgill for the PR. LGTM.
- I have updated the base branch to
release/2.5.0. - In 08d5176 we have similar string with spaces for since annotation in
modules/images/webp-uploads/can-load.phpfile but it working fine for that release don't know what has changed 🤔
|
Thanks for adjusting the branch, @mukeshpanchal27. I noticed the other place where this would have applied and thought the same thing! I assume that one just got adjusted manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where the since command was failing to replace instances of
n.e.x.twhen more than once space occurred between the@sinceand the placeholder version number, e.g., for docblock alignment purposes.Relevant technical choices
While prepping for the 2.5.0 release, I noticed that running
npm run since -- -r 2.5.0missed one case in modules/images/fetchpriority/can-load.php that was added during this release. It looks like this is due to the alignment spacing in the docblock, which is causing the regex pattern to not match. Updating the regex pattern to look for multiple spaces and apply the same number of spaces in the replacement fixes the issue.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.